[bisq-network/bisq] Trade protocol domain improvements (#4566)

chimp1984 notifications at github.com
Mon Sep 28 23:14:14 UTC 2020


@chimp1984 commented on this pull request.



>  @Slf4j
-public class SellerSendsDepositTxAndDelayedPayoutTxMessage extends TradeTask {
-    @SuppressWarnings({"unused"})
-    public SellerSendsDepositTxAndDelayedPayoutTxMessage(TaskRunner taskHandler, Trade trade) {
+public class SellerSendsDepositTxAndDelayedPayoutTxMessage extends SendMailboxMessageTask {

The SendMailboxMessageTask base class is already handling most. The exta code for resend has some differences so the same part is not worth IMO to extract to another superclass. If you compate both classes you see that there are small differences.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4566#discussion_r496285514
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200928/ebed50b5/attachment.html>


More information about the bisq-github mailing list