[bisq-network/bisq] [WIP] Add segwit support to the BTC wallet (#4568)
Oscar Guindzberg
notifications at github.com
Tue Sep 29 00:24:49 UTC 2020
<!--
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->
This is just the BTC wallet.
Trade protocol keeps using legacy addresses.
This PR does not require a hardfork.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4568
-- Commit Summary --
* Use bitcoinj 0.15.8 (commit 9cdd3b4)
* Create a P2WPKH keychain for new btc wallets
* Add a P2WPKH keychain for existing wallets
* AddressEntry: Add boolean segwit flag
* Stop using LegacyAddress for btc addresses
* Fix log msg in BtcCoinSelector
* Comment out segwit BSQ account path
* TradeWalletService: adapt to segwit wallet
* WalletService: adapt to segwit wallet
* New AddressEntry: use different script types
* AddressEntryList: arbitrator entry use P2PKH
* Add segwit/legacy checbox for address creation
* Serialize tx without segwit
* Don't create an extra address at startup
* Don't create a wallet address when not needed
* Remove unused WalletService.findKeyFromPubKeyHash()
* Remove unused WalletService.freshKey()
* Remove unused import
-- File Changes --
M build.gradle (2)
M core/src/main/java/bisq/core/app/WalletAppSetup.java (2)
M core/src/main/java/bisq/core/btc/model/AddressEntry.java (26)
M core/src/main/java/bisq/core/btc/model/AddressEntryList.java (31)
M core/src/main/java/bisq/core/btc/setup/BisqKeyChainGroupStructure.java (12)
M core/src/main/java/bisq/core/btc/setup/WalletConfig.java (14)
M core/src/main/java/bisq/core/btc/wallet/BtcCoinSelector.java (2)
M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (50)
M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (61)
M core/src/main/java/bisq/core/btc/wallet/WalletService.java (54)
M core/src/main/resources/i18n/displayStrings.properties (1)
M desktop/src/main/java/bisq/desktop/main/funds/deposit/DepositView.java (25)
M gradle/witness/gradle-witness.gradle (2)
M proto/src/main/proto/pb.proto (1)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4568.patch
https://github.com/bisq-network/bisq/pull/4568.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4568
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200928/23727e20/attachment.html>
More information about the bisq-github
mailing list