[bisq-network/bisq] Trade protocol domain improvements (#4566)
sqrrm
notifications at github.com
Tue Sep 29 09:40:38 UTC 2020
@sqrrm commented on this pull request.
> @Slf4j
-public class SellerSendsDepositTxAndDelayedPayoutTxMessage extends TradeTask {
- @SuppressWarnings({"unused"})
- public SellerSendsDepositTxAndDelayedPayoutTxMessage(TaskRunner taskHandler, Trade trade) {
+public class SellerSendsDepositTxAndDelayedPayoutTxMessage extends SendMailboxMessageTask {
I get that a superclass might not fit well, but I think a helper class to encapsulate the resend code could help clean up the code, and perhaps there other cases where it would be useful.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4566#discussion_r496581346
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200929/48388bf2/attachment.html>
More information about the bisq-github
mailing list