[bisq-network/bisq] Change Venezuelan currency from VEF to VES (#4572)

[Jelle Besseling]

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Fixes #1920

This adds a properties file to supply to java.util.Currency so that it knows the Venezuelan currency is VES. Adding additional data to this class is quite cumbersome. You need to supply a properties file, but it cannot be a class resource, it has to live in an actual file. I placed this logic in BisqExecutable.java but I don't think it's the best location. 

The currency currently has no display name, so the Bisq app defaults to "VES (VES)". I don't know how locale information within the Java jdk can be translated, so please help me with that. Alternatively I could do some checks in various places to check if the display name for VES is requested and we could use our own translation strings.

This code should be removed if we upgrade to Java 11 or newer, because the currency data is updated in those versions.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4572

-- Commit Summary --

  * Change Venezuelan currency from VEF to VES

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqExecutable.java (24)
    A core/src/main/resources/CurrencyData.properties (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4572.patch
https://github.com/bisq-network/bisq/pull/4572.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4572
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200929/97fcae15/attachment.html>