[bisq-network/bisq] Fix NPE in Portfolio View when market price n/a (#5385)
Mawu Eli
notifications at github.com
Thu Apr 1 00:13:33 CEST 2021
@wallclockbuilder approved this pull request.
Created an offer, then set `marketPrice=null;`
Tried viewing the offer.
Got this error in the UI and the following error log.
`[JavaFX Application Thread] ERROR b.c.s.CommonSetup: Stack trace:
java.lang.NullPointerException
at bisq.core.offer.TriggerPriceService.wasTriggered(TriggerPriceService.java:125)
at bisq.core.offer.TriggerPriceService.checkPriceThreshold(TriggerPriceService.java:140)
at bisq.core.offer.TriggerPriceService.lambda$onPriceFeedChanged$4(TriggerPriceService.java:108)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)
at java.base/java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1608)
`
![null pointer exception](https://user-images.githubusercontent.com/2033945/113217886-6aef7f00-9233-11eb-8c9c-9b3bde7ead1a.png)
I'm able to view the offer just fine when the null value is guarded.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5385#pullrequestreview-625760294
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210331/3b001081/attachment.htm>
More information about the bisq-github
mailing list