[bisq-network/bisq] Add BTC/BSQ pair offer & trading tests (#5359)

Stan notifications at github.com
Fri Apr 2 15:46:58 CEST 2021


This is the explanation for code duplication the reviewer will find in the `bisq.apitest.botsupport.util` package.

The `botsupport` pkg should eventually be moved to it's own gradle subproject, and depend only on `:cli`.  Anticipating this, the `botsupport` package has no dependencies on anything below `:cli`.

It does not need to be repeated, but is relevant:  there is a general problem around API code re-use due to JFX dependencies in `:common`.  Client side subprojects cannot depend on the `:common` subproject, and you will find the new BotThread, BotUtilities, FileUtil, etc., are modified copies of the orignals in the common module.

The best solution is to carefully split up the common module into UI and non-UI related modules, as mentioned in the 1 April keybase meeting.  But this work is not in the scope of this PR and the API v1 rollout.  When this does happen, duplicate code in the botsupport pkg will be replaced by dependencies.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5359#issuecomment-812537937
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210402/5b85d99a/attachment.htm>


More information about the bisq-github mailing list