[bisq-network/bisq] DAO out of sync causes Bisq fee to be validated incorrectly (#5393)

[jmacxx]

Since 1.6.0, Bisq has had [this feature](https://github.com/bisq-network/bisq/issues/5119) to validate trading fees paid.  With this model, Bisq trading partners check each other's transactions thus ensuring fees are paid (which is what keeps Bisq running).  

However it is possible for a Bisq node's DAO to be out of sync and thus have a differing view on what the sufficient fee should be.  

For example user Alice's node expected trading partner Bob to have paid a fee of 2.11 BSQ; in fact Bob had paid the correct fee of 1.82 BSQ.  In this case Alice's node had an out of sync DAO which told them that Bob should have used a fee rate from two months ago which is higher than today's fee rate.  Bisq complains to Alice that her counterparty did not pay enough fees and that a support ticket should be opened.

There are already [leniency checks](https://github.com/bisq-network/bisq/pull/5347) built onto the fee validation to allow historical fee rates.  But in this case the appropriate fee rate was unknown to Alice since her DAO was stuck, **and this was only evident by looking at DAO -> Dao Status screen**.

The solution for Alice was to re-sync the DAO.

---

Ideally we would not have the situation where the DAO can silently get stuck.

Related issue: https://github.com/bisq-network/bisq/issues/5329

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5393
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210405/af141925/attachment.htm>