[bisq-network/bisq] Encrypt or remove saved trader chats and trade data on local Bisq instances (#5396)

[chimp1984]

I think the benefits/costs have to be considered. Not a strong opinion here, but I guess there are more important and easier to achieve improvement.

Some considerations:
- Encryption/decrytption causes delay and higher CPU usage at persistence. This might be critical as shutdown on slow harddrives/cpus
- If user uses the wallet password we could use that but what to do if users has not set up a password?
- If user changes password, all files need to be decrypted and re-encrypted. Any bug/mistake/race condition can lead to lost data
- Backups with an older password which the user might have not saved will become inaccessible
- If one gets access to your local data he might get also a keylogger set up, rendering pw protection useless

Not saying it should not be done, just that it is not trivial and comes with some risks and complexities.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5396#issuecomment-814558355
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210406/55671a7a/attachment.htm>