[bisq-network/bisq] Complete API support for BSQ/BTC trade pair (#5412)

Stan notifications at github.com
Thu Apr 15 19:47:38 CEST 2021


- Finished API server's verify bsq payment impl.

- Added `verifybsqsenttoaddress` method to CLI.

- Added `verifybsqsenttoaddress-help.txt` to server.

- Fixed client `getoffers`, `getmyoffers` to work with BSQ offers.

- Configure call rate meter for `CreateCryptoCurrencyPaymentAccount`.

- Added `CreateBSQOffersTest`, `TakeBuyBSQOfferTest`, `TakeSellBSQOfferTest`.
  The first tests bsq offer creation, the second & third test bsq trade protocol, and includes bsq payment verification checks.

- Made test dispute agent registration a test harness opt.
  It was a test case opt, now it happens by default.

- Moved some global test constants into `ApiTestConfig`.
  Adjusted affected test cases.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5412

-- Commit Summary --

  * Add verifyBsqSentToAddress to GrpcWalletsService, CoreApi
  * Complete API support for BSQ/BTC trade pair
  * Test BSQ/BTC trade pair
  * Configure call rate meter for CreateCryptoCurrencyPaymentAccount

-- File Changes --

    M apitest/src/main/java/bisq/apitest/Scaffold.java (22)
    M apitest/src/main/java/bisq/apitest/config/ApiTestConfig.java (17)
    M apitest/src/test/java/bisq/apitest/method/MethodTest.java (33)
    M apitest/src/test/java/bisq/apitest/method/RegisterDisputeAgentsTest.java (3)
    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (20)
    M apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (6)
    A apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (252)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (101)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (130)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (18)
    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (52)
    A apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (304)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (51)
    A apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (309)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (57)
    M apitest/src/test/java/bisq/apitest/scenario/OfferTest.java (14)
    M apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (24)
    M cli/src/main/java/bisq/cli/CliMain.java (23)
    A cli/src/main/java/bisq/cli/CryptoCurrencyUtil.java (35)
    M cli/src/main/java/bisq/cli/GrpcClient.java (53)
    M cli/src/main/java/bisq/cli/Method.java (1)
    M cli/src/main/java/bisq/cli/opts/CreatePaymentAcctOptionParser.java (2)
    A cli/src/main/java/bisq/cli/opts/VerifyBsqSentToAddressOptionParser.java (61)
    M core/src/main/java/bisq/core/api/CoreApi.java (4)
    A core/src/main/resources/help/verifybsqsenttoaddress-help.txt (39)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java (1)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (17)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5412.patch
https://github.com/bisq-network/bisq/pull/5412.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5412
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210415/1778cfba/attachment-0001.htm>


More information about the bisq-github mailing list