[bisq-network/bisq] Match SEPA accounts IBANs to selected participating countries #241 (#5419)

allykaz notifications at github.com
Mon Apr 19 13:20:59 CEST 2021


Auto fills bank county code based on a valid IBAN code and validates the IBAN on the selected bank country code.

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Fixes #241

Auto-fills the bank country code based on the IBAN entered, conversely makes the selected bank country code part of the validation of the IBAN.

Wasn't too sure on how this should be tested (i.e. testpad), so thought I would leave to see if this is considered the right approach first.  

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5419

-- Commit Summary --

  * Match SEPA accounts IBANs to selected participating countries #241

-- File Changes --

    M desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaForm.java (33)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5419.patch
https://github.com/bisq-network/bisq/pull/5419.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5419
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210419/13637d6b/attachment.htm>


More information about the bisq-github mailing list