[bisq-network/bisq] Size popup proportional to amount of text shown (#5424)
jmacxx
notifications at github.com
Wed Apr 21 00:28:32 CEST 2021
This is a followup to #5399 which cleans up a minor display issue.
CashByMail terms are defined by the offer maker, some users have only 1 line of text, others have a lengthy contract.
For the cases where only 1 line is shown, the large popup taking the whole screen looks a bit ridiculous, so here we vertically size the popup proportional to the number of lines in the message (with limits to not be < 20% or > 70% of allowable height).
---
Here are some example screenshots comparing the results with lots of text, and just one line.
![image](https://user-images.githubusercontent.com/47253594/115471174-28e7a680-a1fd-11eb-9343-eb87742c8a03.png)
![image](https://user-images.githubusercontent.com/47253594/115471133-1b322100-a1fd-11eb-94cf-5645553b3ed8.png)
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5424
-- Commit Summary --
* Size GenericMessageWindow proportional to amount of text shown
-- File Changes --
M desktop/src/main/java/bisq/desktop/main/overlays/windows/GenericMessageWindow.java (12)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5424.patch
https://github.com/bisq-network/bisq/pull/5424.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5424
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210420/97b14903/attachment-0001.htm>
More information about the bisq-github
mailing list