[bisq-network/bisq] Fix cli test that blocks building on Windows (#5436)
BtcContributor
notifications at github.com
Fri Apr 23 11:22:46 CEST 2021
This fix a path issue that was blocking users to build Bisq on Windows from terminal when using a command like _gradlew.bat build_
Fix tested on Windows and Linux/macOS.
The error was:
```
Task :cli:test FAILED
bisq.cli.opt.OptionParsersTest > testCreatePaymentAcctOptParserWithInvalidPaymentFormOptValueShouldThrowException() FAILED
org.opentest4j.AssertionFailedError at OptionParsersTest.java:179
```
Due to:
```
testCreatePaymentAcctOptParserWithInvalidPaymentFormOptValueShouldThrowException()
org.opentest4j.AssertionFailedError: expected: <json payment account form '/tmp/milkyway/solarsystem/mars' could not be found> but was: <json payment account form '\tmp\milkyway\solarsystem\mars' could not be found>
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1124)
at bisq.cli.opt.OptionParsersTest.testCreatePaymentAcctOptParserWithInvalidPaymentFormOptValueShouldThrowException(OptionParsersTest.java:179)
```
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5436
-- Commit Summary --
* Fix cli test that blocks building on Windows
-- File Changes --
M cli/src/test/java/bisq/cli/opt/OptionParsersTest.java (6)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5436.patch
https://github.com/bisq-network/bisq/pull/5436.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5436
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210423/d93b82f7/attachment.htm>
More information about the bisq-github
mailing list