[bisq-network/bisq] Add missing check if tx was in correct phase (#5444)

sqrrm notifications at github.com
Wed Apr 28 11:28:33 CEST 2021


@sqrrm commented on this pull request.



> +                    .filter(e -> periodService.isTxInPhaseAndCycle(e.getTxId(), DaoPhase.Phase.BLIND_VOTE, blockHeight))
+                    .filter(e -> e.getTxId() != null)

I think it would be better to reverse the order of the filters to filter out null txid before using it.

Otherwise it looks correct.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5444#pullrequestreview-646833353
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210428/581cb52f/attachment.htm>


More information about the bisq-github mailing list