[bisq-network/bisq] Add fiat equivalent for Total Amount & Security Deposit for both makers and sellers (#5452)

[BtcContributor]

Now the recap of the trade displays also the fiat equivalent for Total Amount & Security Deposit for both makers and sellers.

Fix also the Total Amount displayed as a taker of a Sell btc trade when using bsq as trading fees (Bsq was not displayed in Total Amount).

**Maker, btc trading fee, previously**
<img width="452" alt="maker_btc_old" src="https://user-images.githubusercontent.com/79100296/116713854-791cf080-a9d5-11eb-8ea6-d6b8c6d97bae.png">

**Maker, btc trading fee, now**
<img width="449" alt="maker_btc_new" src="https://user-images.githubusercontent.com/79100296/116720169-2d217a00-a9dc-11eb-8d1d-f827f4a51bde.png">

**Taker, btc trading fee, previously**
<img width="458" alt="taker_btc_old" src="https://user-images.githubusercontent.com/79100296/116725147-dcad1b00-a9e1-11eb-9764-2d879a7829ac.png">


**Taker, btc trading fee, now**
<img width="457" alt="taker_btc_new" src="https://user-images.githubusercontent.com/79100296/116720192-314d9780-a9dc-11eb-9ca7-0a288800464d.png">

**Maker, bsq trading fee, previously**
<img width="444" alt="maker_bsq_old" src="https://user-images.githubusercontent.com/79100296/116713988-9356ce80-a9d5-11eb-8612-99099138f6d7.png">

**Maker, bsq trading fee, now**
<img width="446" alt="maker_bsq_new" src="https://user-images.githubusercontent.com/79100296/116720208-36124b80-a9dc-11eb-90df-cc7fd08c74b8.png">

**Taker, bsq trading fee, previously** -> THIS IS INCORRECT AS BSQ TRADING FEES ARE NOT DISPLAYED IN TOTAL AMOUNT
<img width="447" alt="taker_bsq_old" src="https://user-images.githubusercontent.com/79100296/116723438-d61da400-a9df-11eb-9990-5b3a8f92d2cb.png">

**Taker, bsq trading fee, now**
<img width="448" alt="taker_bsq_new" src="https://user-images.githubusercontent.com/79100296/116720222-3a3e6900-a9dc-11eb-832f-6d8048d92577.png">

When security deposit is not the minimum for example, this is how it looks like:

<img width="448" alt="percentage" src="https://user-images.githubusercontent.com/79100296/116721525-aff70480-a9dd-11eb-89c1-4bcd8bc20668.png">

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5452

-- Commit Summary --

  * Add fiat equivalent for Total Amount & Security Deposit for both makers and sellers
  * Restore totalToPay as 'final' as before
  * Notice when the security deposit is the minimum possible
  * Add fiat conversion also for trade amount when making a trade to sell btc

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (33)
    M desktop/src/main/java/bisq/desktop/main/offer/OfferDataModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (33)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5452.patch
https://github.com/bisq-network/bisq/pull/5452.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5452
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210430/e590c984/attachment.htm>