[bisq-network/bisq] Fix issue with extraData field when editing offer (#5651)

jmacxx notifications at github.com
Tue Aug 3 05:58:49 CEST 2021


Reported by @stakoholic, when editing an offer some information was not being transferred.

`extraData` is used for the account age and other custom fields like F2F city.
So when editing an offer the extraData should be obtained from the edited offer not the original one.

Fixes #5597
FYI @ghubstan this one line fix also needs carrying over to the current editoffer API work.

---

### Testing:

You have an Amazon gift card account which is 4 days old (for example).
Create an F2F account which specifies city as 'Paris' and additional information as "ask for Freddie".

**Prior version: (bug)**

- Create offer to buy 0.01 BTC using Amazon gift card.
- Edit the offer changing payment account to F2F.
- Look at the offer in the order book.  
- It should show the F2F city ('Paris') but it is blank.
- It should show additional information ("ask for Freddie") but it is blank.
- It should show the account age as 0 days old but instead shows it as 4 days old.
 
![image](https://user-images.githubusercontent.com/47253594/127954270-f07c9a5e-7a61-413a-a9f0-5d07862afbe8.png)


**Version with fix applied:**

- Create offer to buy 0.01 BTC using Amazon gift card.
- Edit the offer changing payment account to F2F.
- Look at the offer in the order book.  
- It shows the F2F city ('Paris').
- It shows additional information as "ask for Freddie".
- It shows the account age as 0 days old.

![image](https://user-images.githubusercontent.com/47253594/127954784-02871aa6-c90c-4565-8e78-50d01ca91446.png)

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5651

-- Commit Summary --

  * fix issue with extraData field when editing offer

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5651.patch
https://github.com/bisq-network/bisq/pull/5651.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5651
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210802/8cb81e65/attachment.htm>


More information about the bisq-github mailing list