[bisq-network/bisq] Add UI OfferBook list add/remove checks (#5659)
Stan
notifications at github.com
Wed Aug 18 19:36:30 CEST 2021
@ghubstan commented on this pull request.
> offer.getId(),
- hashOfPayload.getHex());
+ hashOfPayload == null ? "null" : hashOfPayload.getHex());
+ }
+
+ // The OfferBookListItem with a null or matching payload-hash was not found.
+ // However, when the API's CLI is used to edit and deactivate an offer
+ // in the same command, the edited offer is not re-published (and cannot be
+ // found in local storage). In this case, we need to remove the deactivated
+ // offer from the list if the local store does not contain an offer with a
+ // matching offerId.
+ if (!isStoredLocally(offer)) {
+ Optional<OfferBookListItem> viewItem = getOfferBookListItem(offer);
+ viewItem.ifPresent((item) -> {
+ offerBookListItems.remove(item);
Commit fb4e00fb6bf6c6fbac536292d3b930f3c04cacf0 fixes the bug that caused me to add this workaround, and it has been removed in PR https://github.com/bisq-network/bisq/pull/5666
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5659#discussion_r691467813
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210818/9dcef52f/attachment.htm>
More information about the bisq-github
mailing list