[bisq-network/bisq] Fix incorrect start height for block request (PR #5875)

[chimp1984]

I think the issue is when the blocks request is faster then the blockhash requests from other nodes. So might be a bit of race conditions... 
But to be sure that process is right: 
- Create some blocks while app is shut down
- Start app (full mode/lite-monitor mode). should persiste latest block (triggered by hash response)
- Restart
- Does not parse as blockheight of persisted dao state is latest height, but start block calculated with +1 so the code for starting to parse ignores the request as requested block is in the future. One can check the logs at `getStartBlockHeight` in `BsqNode` and in `startParseBlocks` in `FullNode`. The relevant code is:
```
if (startBlockHeight <= chainHeight) {
                        parseBlocksOnHeadHeight(startBlockHeight, chainHeight);
                    }```
This is false in case the startBlockHeight is one block higher as the chainHeight.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5875#issuecomment-983098607
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211130/5fbb9740/attachment.htm>