[bisq-network/bisq] Always use fresh address for MULTI_SIG context (PR #5885)

[jmacxx]

Fixes #5880, Fixes #5661

It is currently possible for the user to choose a receiving address from `Funds -> Receive`, request their exchange withdrawal to that address; then continue to take an offer on Bisq.  If this happens, the funds deposited from the exchange will never show in Bisq, as the same address is used in the trade with a MULTI_SIG context meaning that it is forever excluded from balance calculations.

Solution is to always generate a fresh address when obtaining a MULTI_SIG reservation.


### Testing (pre)

1. Bob has 2 bech32 addresses shown in Funds -> Receive,
2. Alice creates offer
3. Bob presses Take Offer, then Next Step.  One of the 2 addresses is reserved for trade funding.
4. Bob takes note of the receiving address still shown in Funds -> Receive: "address_b".
4. Bob completes the Take Offer process.
5. Bob deposits to "address_b" (picked it from Funds -> Receive earlier).
6. Bring the trade to normal completion.
7. Notice that the deposited amount is missing, but is shown in Transaction list & the Emergency Wallet (ctrl-e).
 

### Testing (post)

1. Bob has 2 bech32 addresses shown in Funds -> Receive,
2. Alice creates offer
3. Bob presses Take Offer, then Next Step.  One of the 2 addresses is reserved for trade funding.
4. Bob takes note of the receiving address still shown in Funds -> Receive: "address_b".
4. Bob completes the Take Offer process.
5. Bob deposits to "address_b" (picked it from Funds -> Receive earlier).
6. Bring the trade to normal completion.
7. Notice that the deposited amount is OK.


 



You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5885

-- Commit Summary --

  * Always use fresh address for MULTI_SIG context

-- File Changes --

    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (3)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5885.patch
https://github.com/bisq-network/bisq/pull/5885.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5885
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211201/5ff9bb67/attachment.htm>