[bisq-network/bisq] Add support to duplicate BSQ swap offers (PR #5886)

Christoph Atteneder notifications at github.com
Fri Dec 3 11:27:29 CET 2021


> @ripcurlx ACK for invocation from Open Offers. It should work the same from History. Looks like it was an issue even before this PR, FWIW.
> 
> ```
> Dec-02 13:40:13.522 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
> Dec-02 13:40:13.523 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableMessage= No value present 
> Dec-02 13:40:13.523 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableClass= class java.util.NoSuchElementException 
> Dec-02 13:40:13.524 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Stack trace:
> java.util.NoSuchElementException: No value present
>     at java.base/java.util.Optional.orElseThrow(Optional.java:382)
>     at bisq.desktop.main.portfolio.closedtrades.ClosedTradesView.lambda$initialize$10(ClosedTradesView.java:268)
>     at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86)
>     at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
>     at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
>     at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
>     at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
>     at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
>     at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:49)
>     at javafx.event.Event.fireEvent(Event.java:198)
>     at javafx.scene.control.MenuItem.fire(MenuItem.java:459)
>     at com.sun.javafx.scene.control.ContextMenuContent$MenuItemContainer.doSelect(ContextMenuContent.java:1385)
>     at com.sun.javafx.scene.control.ContextMenuContent$MenuItemContainer.lambda$createChildren$12(ContextMenuContent.java:1338)
> ```

Missed to add it there as well ☝️ 
I'm thinking about adding an additional action column (copy icon) as well to make it more visible as mentioned by @chimp1984.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5886#issuecomment-985403115
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211203/b7e53562/attachment.htm>


More information about the bisq-github mailing list