[bisq-network/bisq] API XMR/BTC trading pair support (PR #5893)
Stan
notifications at github.com
Fri Dec 3 17:22:39 CET 2021
New API features:
- Create XMR payment accts with API.
- Create XMR offers with API.
- Trade XMR using v1 protocol, not swapping.
Testing new API XMR support, docs:
- Created apitest cases for XMR support.
- Created XMR/BTC trade simulation script (regtest only).
- Updated api beta test guide for XMR support.
Based on PR https://github.com/bisq-network/bisq/pull/5876
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5893
-- Commit Summary --
* Adjust bsq-swap-offer related gRPC services & msgs
* Adjust bsq-swap-offer related gRPC daemon services
* Partially adjust api proto wrappers for bsq-swap support
* Add String getRole(BsqSwapTrade trade) method
* Add conveniences isFiatOffer(offer), isAltcoinOffer(offer)
* Partially adjust core api for bsq-swap support
* Paritally adjust bsq-swap-offer related gRPC CLI side classes
* Paritally adjust bsq-swap-offer related apitest cases
* Normalize API gRPC bsq-swap related protos & wrappers
* Merge branch 'master' into 1-basic-api-bsqswap-support
* Add CLI output IntegerColumn
* Adjust API 'gettrade' for Bsq swaps
* Try to hide from pesky codacy
* Merge branch 'master' into 1-basic-api-bsqswap-support
* Remove Get/Take BSQSwap Offer/Trade rpc service defs
* Refactor GrpcTradesService: use GetTrade & TakeOffer services for BSQ swaps
* Refactor core.api trade service implemenentations for BSQ swaps
* Adjust CLI to support getting/taking BSQ swaps
* Adjust apitest cases to rpc BSQ wwap related changes
* Merge branch 'master' into 2-api-bsq-swap-scratch
* Merge branch 'master' into 2-refactor-api-bsqswap-support
* Remove API createoffer's paymentAcctId request param (BSQ swap)
* Adjust createoffer opt parser/test for bsq swaps
* Adjust createoffer opt parser for bsq swaps
* Tighten createoffer param validation (only bsq swaps supported)
* Re- at Disable method tests (don't run 2x from gradle)
* Adjust CliMain's createoffer for BSQ swaps
* Add CLI createoffer smoketest (for bsq swaps)
* Fix help text typo
* Make rpc GetOfferCategory service work for my+avail offers
* Block attempts to edit BsqSwap offers from CLI
* Test blocking attempts to edit BsqSwap offers on server
* There is no --swap opt in editoffer command
* Force rebuild after github action ECONNRESET
* Revert "There is no --swap opt in editoffer command"
* Add apitest/scripts/bsqswap-simulation.sh script
* Remove unused function outputs
* Adjust core api method help docs for bsq swaps
* Allow unrecognized options in OfferIdOptionParser where appropriate
* Update API docs for Bitcoin Core version v22.0
* Adjust API beta-test guide for BSQ swaps
* Merge branch 'master' into 5-api-bsqswap-simulation-n-docs-update
* Use calculated offer maker fee, do not re-calculate it
* Use offer instance to determine ownership, not it's id
* Calculate offer.makerFee if offer is bsq-swap
* Add more readable toString method to MutableOfferPayloadFields
* Refactor api.core side editoffer validation & fix bug
* Adjust API CorePaymentAccountsService for creating XMR accts
* Allow mkt price lookup for any altcoin from API
* Adjust API cli-side CryptoCurrencyUtil & OffersServiceRequest for XMR support
* Make altcoin offer sorting method names more generic
* Adjust CLI opts parsers & opt parsing test for XMR support
* Test API XMR support
* Add CliMain.main(args) tests
* Add new regtest apitest/scripts/trade-xmr-simulation.sh
* Add a few more checks on editedOffer.getUseMarketBasedPrice()
* Do not run 2x from gradle terminal cmd
* Add missing --currency-code=bsq param to createoffer example
* Tell user bsqswap offer cannot be edited, but can be canceled at no charge
* Merge branch '5-api-bsqswap-simulation-n-docs-update' into 6-api-xmr-trading
* Merge branch 'master' into 6-api-xmr-trading
-- File Changes --
M apitest/docs/api-beta-test-guide.md (36)
M apitest/docs/build-run.md (2)
A apitest/scripts/bsqswap-simulation-utils.sh (79)
A apitest/scripts/bsqswap-simulation.sh (90)
M apitest/scripts/limit-order-simulation.sh (2)
M apitest/scripts/rolling-offer-simulation.sh (2)
M apitest/scripts/trade-simulation-env.sh (86)
M apitest/scripts/trade-simulation-utils.sh (21)
M apitest/scripts/trade-simulation.sh (13)
A apitest/scripts/trade-xmr-simulation.sh (122)
M apitest/src/main/java/bisq/apitest/ApiTestMain.java (2)
M apitest/src/main/java/bisq/apitest/linux/AbstractLinuxProcess.java (2)
M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (41)
M apitest/src/test/java/bisq/apitest/method/offer/BsqSwapOfferTest.java (18)
M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (4)
A apitest/src/test/java/bisq/apitest/method/offer/CreateXMROffersTest.java (282)
M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (467)
M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (24)
M apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTest.java (110)
M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (2)
A apitest/src/test/java/bisq/apitest/method/trade/TakeBuyXMROfferTest.java (175)
A apitest/src/test/java/bisq/apitest/method/trade/TakeSellXMROfferTest.java (183)
M apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java (4)
M apitest/src/test/java/bisq/apitest/scenario/OfferTest.java (25)
M apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (26)
M cli/src/main/java/bisq/cli/CliMain.java (81)
M cli/src/main/java/bisq/cli/CryptoCurrencyUtil.java (2)
M cli/src/main/java/bisq/cli/GrpcClient.java (90)
M cli/src/main/java/bisq/cli/opts/AbstractMethodOptionParser.java (2)
M cli/src/main/java/bisq/cli/opts/CancelOfferOptionParser.java (16)
M cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java (15)
M cli/src/main/java/bisq/cli/opts/CreateOfferOptionParser.java (54)
M cli/src/main/java/bisq/cli/opts/CreatePaymentAcctOptionParser.java (2)
M cli/src/main/java/bisq/cli/opts/EditOfferOptionParser.java (32)
M cli/src/main/java/bisq/cli/opts/GetOffersOptionParser.java (2)
M cli/src/main/java/bisq/cli/opts/GetPaymentAcctFormOptionParser.java (2)
R cli/src/main/java/bisq/cli/opts/OfferIdOptionParser.java (18)
M cli/src/main/java/bisq/cli/opts/OptLabel.java (1)
M cli/src/main/java/bisq/cli/opts/SetTxFeeRateOptionParser.java (2)
M cli/src/main/java/bisq/cli/opts/TakeOfferOptionParser.java (19)
M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (97)
M cli/src/main/java/bisq/cli/request/TradesServiceRequest.java (16)
M cli/src/main/java/bisq/cli/table/builder/AbstractTradeListBuilder.java (40)
M cli/src/main/java/bisq/cli/table/builder/TableBuilderConstants.java (3)
M cli/src/main/java/bisq/cli/table/builder/TradeDetailTableBuilder.java (112)
M cli/src/main/java/bisq/cli/table/builder/TradeTableColumnSupplier.java (88)
A cli/src/main/java/bisq/cli/table/column/IntegerColumn.java (93)
M cli/src/test/java/bisq/cli/AbstractCliTest.java (172)
A cli/src/test/java/bisq/cli/CreateOfferSmokeTest.java (66)
A cli/src/test/java/bisq/cli/EditBsqOffersSmokeTest.java (41)
A cli/src/test/java/bisq/cli/EditXmrOffersSmokeTest.java (100)
M cli/src/test/java/bisq/cli/GetOffersSmokeTest.java (41)
M cli/src/test/java/bisq/cli/opts/OptionParsersTest.java (162)
M core/src/main/java/bisq/core/api/CoreApi.java (37)
M core/src/main/java/bisq/core/api/CoreOffersService.java (154)
M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (53)
M core/src/main/java/bisq/core/api/CorePriceService.java (17)
M core/src/main/java/bisq/core/api/CoreTradesService.java (31)
M core/src/main/java/bisq/core/api/CoreWalletsService.java (54)
M core/src/main/java/bisq/core/api/EditOfferValidator.java (144)
D core/src/main/java/bisq/core/api/model/BsqSwapOfferInfo.java (227)
M core/src/main/java/bisq/core/api/model/BsqSwapTradeInfo.java (286)
M core/src/main/java/bisq/core/api/model/ContractInfo.java (1)
M core/src/main/java/bisq/core/api/model/OfferInfo.java (298)
M core/src/main/java/bisq/core/api/model/TradeInfo.java (357)
M core/src/main/java/bisq/core/api/model/TxInfo.java (24)
A core/src/main/java/bisq/core/api/model/builder/BsqSwapTradeInfoBuilder.java (113)
A core/src/main/java/bisq/core/api/model/builder/OfferInfoBuilder.java (223)
A core/src/main/java/bisq/core/api/model/builder/TradeInfoV1Builder.java (195)
M core/src/main/java/bisq/core/offer/OfferUtil.java (8)
M core/src/main/java/bisq/core/offer/bisq_v1/MutableOfferPayloadFields.java (20)
M core/src/main/java/bisq/core/trade/bisq_v1/TradeUtil.java (21)
M core/src/main/java/bisq/core/trade/protocol/bsq_swap/model/BsqSwapProtocolModel.java (1)
M core/src/main/resources/help/createoffer-help.txt (62)
M core/src/main/resources/help/takeoffer-help.txt (18)
M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (72)
M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (153)
M proto/src/main/proto/grpc.proto (128)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5893.patch
https://github.com/bisq-network/bisq/pull/5893.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5893
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211203/44b82345/attachment-0001.htm>
More information about the bisq-github
mailing list