[bisq-network/bisq] Add support to duplicate BSQ swap offers (PR #5886)

chimp1984 notifications at github.com
Mon Dec 6 17:34:15 CET 2021


@chimp1984 commented on this pull request.



> @@ -572,6 +575,33 @@ private void updateButtonDisableState() {
         isPlaceOfferButtonDisabled.set(createOfferRequested || !inputDataValid || miningPoW.get());
     }
 
+    private void maybeInitializeWithData() {

I meant to have the if check for null could be done at the caller of `maybeInitializeWithData` and then its not a maybe anymore... but no strong opinion either... It just took a bit more effort to understand the code that ways as one need to jump to the method to see whats really going on there to see that its only an optional case if the param is null.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5886#discussion_r763173160
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211206/a4dc0695/attachment.htm>


More information about the bisq-github mailing list