[bisq-network/bisq] Improve shutdown process (PR #5905)
chimp1984
notifications at github.com
Wed Dec 8 02:54:36 CET 2021
I observed several times that the app shutdown got blocked for about 1 minute. I could not find out what blocks it, but I suspect its in the network/tor layer. I added more logs to make it easier to spot the issue and improved the shutdown process as well as reduced the timeouts. There was also a incorrect handling of the tor shutdown process which got fixed.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5905
-- Commit Summary --
* Do not shut down networkNode and Tor in parallel as network node
* Extract duplicated code at shutdown
* Reduce timeouts
-- File Changes --
M core/src/main/java/bisq/core/app/BisqExecutable.java (72)
M core/src/main/java/bisq/core/btc/setup/WalletsSetup.java (2)
M p2p/src/main/java/bisq/network/p2p/P2PService.java (6)
M p2p/src/main/java/bisq/network/p2p/network/Connection.java (12)
M p2p/src/main/java/bisq/network/p2p/network/NetworkNode.java (3)
M p2p/src/main/java/bisq/network/p2p/network/Server.java (3)
M p2p/src/main/java/bisq/network/p2p/network/TorNetworkNode.java (117)
M p2p/src/main/java/bisq/network/p2p/peers/Broadcaster.java (5)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5905.patch
https://github.com/bisq-network/bisq/pull/5905.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5905
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211207/6a43fd27/attachment-0001.htm>
More information about the bisq-github
mailing list