[bisq-network/bisq] Apply Localized Number Formatting To Transaction Details (PR #5902)

Christoph Atteneder notifications at github.com
Thu Dec 9 10:27:29 CET 2021


Changing to a localized formatting broke some tests if a different locale than the US_en is set.
Having DE_de causes following tests to fail:
```
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended

bisq.desktop.main.offer.bisq_v1.createoffer.CreateOfferViewModelTest > testSyncMinAmountWithAmountWhenHigherMinAmountValueIsSet FAILED
    org.junit.ComparisonFailure at CreateOfferViewModelTest.java:222

bisq.desktop.main.offer.bisq_v1.createoffer.CreateOfferViewModelTest > testSyncMinAmountWithAmountWhenSameValueIsSet FAILED
    org.junit.ComparisonFailure at CreateOfferViewModelTest.java:206

bisq.desktop.main.offer.bisq_v1.createoffer.CreateOfferViewModelTest > testSyncMinAmountWithAmountUntilChanged FAILED
    org.junit.ComparisonFailure at CreateOfferViewModelTest.java:166

bisq.desktop.main.offer.bisq_v1.createoffer.CreateOfferViewModelTest > testSyncPriceMarginWithVolumeAndFixedPrice FAILED
    org.junit.ComparisonFailure at CreateOfferViewModelTest.java:237

bisq.desktop.main.offer.bisq_v1.createoffer.CreateOfferViewModelTest > testSyncMinAmountWithAmountWhenZeroCoinIsSet FAILED
    org.junit.ComparisonFailure at CreateOfferViewModelTest.java:189

bisq.desktop.main.offer.offerbook.OfferBookViewModelTest > testGetPrice FAILED
    org.junit.ComparisonFailure at OfferBookViewModelTest.java:453

bisq.desktop.util.DisplayUtilsTest > testFormatSameVolume FAILED
    org.junit.ComparisonFailure at DisplayUtilsTest.java:67

bisq.desktop.util.DisplayUtilsTest > testFormatDifferentVolume FAILED
    org.junit.ComparisonFailure at DisplayUtilsTest.java:79

126 tests completed, 8 failed, 7 skipped

> Task :desktop:test FAILED
```

Could you please adapt those tests, so they don't use the current locale - Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5902#issuecomment-989666492
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211209/2e37b44c/attachment-0001.htm>


More information about the bisq-github mailing list