[bisq-network/bisq] API daemon 'getoffer' & 'gettrade' support for BSQ swaps #1 (PR #5827)
sqrrm
notifications at github.com
Thu Dec 9 16:35:01 CET 2021
@sqrrm approved this pull request.
utACK
@ghubstan I haven't followed other developments, can this be merged or does it need to wait?
> + public static boolean isAltcoinOffer(Offer offer) {
+ return offer.getCounterCurrencyCode().equals("BTC") && !offer.isBsqSwapOffer();
+ }
Is swapOffer not considered an altcoin trade? I guess it makes some sense but also somewhat odd.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5827#pullrequestreview-827823307
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211209/68c02640/attachment.htm>
More information about the bisq-github
mailing list