[bisq-network/bisq] Fix fat finger protection in Offer Entry screen (PR #5914)

[jmacxx]

Normally, for currencies that have a market price feed, Bisq prevents the user from entering offers that are more than 50% away from spot.  It recently came to light that this fat finger protection in Bisq has a flaw.

A certain sequence of focus operations in the enter offer screen causes fat finger protection to turn off, and then the user is no longer protected from making offers that are significantly out of the market.



**To reproduce the issue:**

1. Go to BUY (or SELL) BTC for an market priced asset, e.g. ETH
2. Click Create New Offer
3. Enter 0.25 BTC
4. Tab to the next field.
5. Click the up/down arrow icon to make sure the fixed price edit box is selected at the top.  The price and deviation gets auto-populated to market price and 0% deviation.
6. Enter a fixed price that is 10x higher than market value.
7. Click "Next" and the fat finger protection warning DOES NOT pop up.
8. This is because the deviation still shows 0%.
 

**Video example:**

![fat_finger](https://user-images.githubusercontent.com/47253594/145739125-bbffd40e-6402-4da3-b3bc-7e514772b9fb.gif)




---

_The two lines of code removed by this PR seem to be a relic from < 2018 so its hard to locate the original intent.  Regardless, it will require a good regression test to check that this fix does not affect any other path in the offer UI._


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5914

-- Commit Summary --

  * Fix fat finger protection issue

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferViewModel.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5914.patch
https://github.com/bisq-network/bisq/pull/5914.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5914
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211212/2464a5be/attachment-0001.htm>