[bisq-network/bisq] API XMR/BTC trading pair support (PR #5893)

[Christoph Atteneder]

I just went through the scenarios of creating an XMR account and do a successful trade. Here are my comments as an API user.

- `createcryptopaymentacct`: ☑️ 
I think we should add this to the documentation as we do it for `createpaymentacct` as well. ATM you need to look at simulation scripts to find out how to create altcoin accounts which might be the main use cases for API usage. Maybe we could even just re-use the `createpaymentacct` method with different parameters to make altcoin accounts a first class citizen.

- `createoffer`: ☑️
Is there a reason why we named the payment account id argument `--payment-account` and not `--payment-account-id`? I think it would be more consistent with the other API methods if we would support the argument with ...-id as well. WDYT? 

- `editoffer` ✅ 

### Trading process

Everything worked as expected I only recognized this time that using the `keepfunds` command is necessary to complete the trade (or isn't it?), but when just checking the `gettrade` command there is no change happening. So this might be confusing for API users. 

```
➜  bisq git:(6-api-xmr-trading) ✗ ./bisq-cli --password=mySecret gettrade --trade-id=yfxmel-4f5caead-1ceb-459e-8111-bc5b2f259e42-180
ID      My Role              Price in BTC for 1 XMR  Amount(XMR)  Tx Fee (BTC)  Maker Fee(BSQ)  Deposit Published  Deposit Confirmed  Buyer Cost(BTC)  XMR Sent  XMR Received  Payout Published  Withdrawn  XMR Buyer Address
yfxmel  XMR seller as maker              0.00395772         5.05    0.00002450            0.03  YES                YES                     0.02000000  YES       YES           YES               NO         46tM15KsogEW5MiVmBn7waPF8u8ZsB6aHjJk7BAv1wvMKfWhQ2h2so5BCJ9cRakfPt5BFo452oy3K8UK6L2u2v7aJ3Nf7P2
➜  bisq git:(6-api-xmr-trading) ✗ ./bisq-cli --password=mySecret --port=9998 keepfunds --trade-id=yfxmel-4f5caead-1ceb-459e-8111-bc5b2f259e42-180
funds from trade yfxmel-4f5caead-1ceb-459e-8111-bc5b2f259e42-180 saved in bisq wallet
➜  bisq git:(6-api-xmr-trading) ✗ ./bisq-cli --password=mySecret gettrade --trade-id=yfxmel-4f5caead-1ceb-459e-8111-bc5b2f259e42-180             
ID      My Role              Price in BTC for 1 XMR  Amount(XMR)  Tx Fee (BTC)  Maker Fee(BSQ)  Deposit Published  Deposit Confirmed  Buyer Cost(BTC)  XMR Sent  XMR Received  Payout Published  Withdrawn  XMR Buyer Address
yfxmel  XMR seller as maker              0.00395772         5.05    0.00002450            0.03  YES                YES                     0.02000000  YES       YES           YES               NO         46tM15KsogEW5MiVmBn7waPF8u8ZsB6aHjJk7BAv1wvMKfWhQ2h2so5BCJ9cRakfPt5BFo452oy3K8UK6L2u2v7aJ3Nf7P2
```

Maybe adding another column with trade state?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5893#issuecomment-997849622
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5893/c997849622 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211220/7dcabf88/attachment.htm>