[bisq-network/bisq] API XMR/BTC trading pair support (PR #5893)

[Stan]

> > > Everything worked as expected I only recognized this time that using the keepfunds command is necessary to complete the
> > > trade (or isn't it?), but when just checking the gettrade command there is no change happening.
> > > So this might be confusing for API users.
> 
> This is confusing and seemingly unnecessary to API users, but if it is not done, the completed trade will not be moved from the pending/open trades list (persistence file), to the closed trades list (persistence file). I am almost certain there is a keep funds button click required as the last step in the UI / protocol. (The alternative last step in the UI is to move-funds-to-external-wallet.)
> 
> The `keepfunds` cmd is consistent with the final step in the UI. I think this needs some more study from both of us before I change it to say... automatically moving completed trade from open-trades list to closed-trades list in the "next to last" step of the protocol.

@ripcurlx, do you agree the resolution of this issue deserves its own PR?


-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5893#issuecomment-999901882
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5893/c999901882 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211222/f5823dd7/attachment.htm>