[bisq-network/bisq] Fix API CLI's '--payment-account-id' opt name, document 'createcryptopaymentacct' (PR #5939)

[Stan]

Rename CLI opt '--payment-account' -> '--payment-account-id'.
Resolves https://github.com/bisq-network/bisq/pull/5893#issuecomment-999901254.

Document 'createcryptopaymentacct' in API beta-test guide
Resolves https://github.com/bisq-network/bisq/pull/5893#issuecomment-999902705.

Based on https://github.com/bisq-network/bisq/pull/5938
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5939

-- Commit Summary --

  * Use calculated offer maker fee, do not re-calculate it
  * Use offer instance to determine ownership, not it's id
  * Calculate offer.makerFee if offer is bsq-swap
  * Add more readable toString method to MutableOfferPayloadFields
  * Refactor api.core side editoffer validation & fix bug
  * Adjust API CorePaymentAccountsService for creating XMR accts
  * Allow mkt price lookup for any altcoin from API
  * Adjust API cli-side CryptoCurrencyUtil & OffersServiceRequest for XMR support
  * Make altcoin offer sorting method names more generic
  * Adjust CLI opts parsers & opt parsing test for XMR support
  * Test API XMR support
  * Add CliMain.main(args) tests
  * Add new regtest apitest/scripts/trade-xmr-simulation.sh
  * Add a few more checks on editedOffer.getUseMarketBasedPrice()
  * Do not run 2x from gradle terminal cmd
  * Merge branch '5-api-bsqswap-simulation-n-docs-update' into 6-api-xmr-trading
  * Merge branch 'master' into 6-api-xmr-trading
  * Use string in BigDecimal ctor, and make codacy happy too
  * Deprecate API 'getmyoffer'
  * Merge branch 'master' into 7-deprecate-api-getmyoffer
  * Rename CLI opt '--payment-account' -> '--payment-account-id'
  * Document 'createcryptopaymentacct' in API beta-test guide

-- File Changes --

    M apitest/docs/api-beta-test-guide.md (53)
    M apitest/scripts/bsqswap-simulation.sh (2)
    M apitest/scripts/limit-order-simulation.sh (2)
    M apitest/scripts/rolling-offer-simulation.sh (2)
    M apitest/scripts/trade-simulation-env.sh (45)
    M apitest/scripts/trade-simulation-utils.sh (10)
    M apitest/scripts/trade-simulation.sh (2)
    A apitest/scripts/trade-xmr-simulation.sh (122)
    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (26)
    M apitest/src/test/java/bisq/apitest/method/offer/BsqSwapOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (10)
    A apitest/src/test/java/bisq/apitest/method/offer/CreateXMROffersTest.java (282)
    M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (322)
    M apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java (11)
    M apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (2)
    A apitest/src/test/java/bisq/apitest/method/trade/TakeBuyXMROfferTest.java (175)
    A apitest/src/test/java/bisq/apitest/method/trade/TakeSellXMROfferTest.java (183)
    M apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java (12)
    M apitest/src/test/java/bisq/apitest/scenario/OfferTest.java (25)
    M apitest/src/test/java/bisq/apitest/scenario/TradeTest.java (24)
    M cli/src/main/java/bisq/cli/CliMain.java (2)
    M cli/src/main/java/bisq/cli/CryptoCurrencyUtil.java (2)
    M cli/src/main/java/bisq/cli/GrpcClient.java (10)
    M cli/src/main/java/bisq/cli/Method.java (3)
    M cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java (18)
    M cli/src/main/java/bisq/cli/opts/CreateOfferOptionParser.java (4)
    M cli/src/main/java/bisq/cli/opts/EditOfferOptionParser.java (3)
    M cli/src/main/java/bisq/cli/opts/GetOffersOptionParser.java (2)
    M cli/src/main/java/bisq/cli/opts/OptLabel.java (2)
    M cli/src/main/java/bisq/cli/opts/TakeOfferOptionParser.java (4)
    M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (36)
    M cli/src/test/java/bisq/cli/AbstractCliTest.java (172)
    M cli/src/test/java/bisq/cli/CreateOfferSmokeTest.java (39)
    A cli/src/test/java/bisq/cli/EditBsqOffersSmokeTest.java (41)
    A cli/src/test/java/bisq/cli/EditXmrOffersSmokeTest.java (100)
    M cli/src/test/java/bisq/cli/GetOffersSmokeTest.java (1)
    M cli/src/test/java/bisq/cli/opts/OptionParsersTest.java (38)
    M core/src/main/java/bisq/core/api/CoreApi.java (13)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (114)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (53)
    M core/src/main/java/bisq/core/api/CorePriceService.java (17)
    M core/src/main/java/bisq/core/api/EditOfferValidator.java (134)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (11)
    M core/src/main/java/bisq/core/offer/bisq_v1/MutableOfferPayloadFields.java (20)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (13)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (2)
    M proto/src/main/proto/grpc.proto (3)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5939.patch
https://github.com/bisq-network/bisq/pull/5939.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5939
You are receiving this because you are subscribed to this thread.

Message ID: <bisq-network/bisq/pull/5939 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211227/e1e71c61/attachment-0001.htm>