[bisq-network/bisq] Add coin input control (#5142)

chimp1984 notifications at github.com
Mon Feb 1 03:43:40 CET 2021


Adds input selection for BSQ send transactions. We use a utxo based model in contrast to the address based model in the Funds screen. If any dev wants to apply that to the funds screen as well would be good. Also to hide it in a popup as it is a bit technical and might confuse some users.

<img width="1198" alt="Screen Shot 2021-01-31 at 21 30 01" src="https://user-images.githubusercontent.com/54558767/106408773-1f744c80-640d-11eb-87a3-6929dd6080f9.png">

<img width="880" alt="Screen Shot 2021-01-31 at 21 29 41" src="https://user-images.githubusercontent.com/54558767/106408771-1c795c00-640d-11eb-9506-c0884c1e769b.png">

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5142

-- Commit Summary --

  * Extract onSendBsq method, return early
  * Add refreshValidation method
  * Implement isDustAttackUtxo protection
  * Add addButtonCheckBoxWithBox method with top param
  * Add support for utxo set used in coin selection if set
  * Add getSpendableBsqTransactionOutputs and getSpendableNonBsqTransactionOutputs
  * Add TxInputSelectionWindow for coin input selection.

-- File Changes --

    M core/src/main/java/bisq/core/btc/wallet/BisqDefaultCoinSelector.java (21)
    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (42)
    M core/src/main/java/bisq/core/btc/wallet/NonBsqCoinSelector.java (8)
    M core/src/main/resources/i18n/displayStrings.properties (5)
    M desktop/src/main/java/bisq/desktop/components/InputTextField.java (11)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (275)
    A desktop/src/main/java/bisq/desktop/main/overlays/windows/TxInputSelectionWindow.java (246)
    M desktop/src/main/java/bisq/desktop/util/FormBuilder.java (13)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5142.patch
https://github.com/bisq-network/bisq/pull/5142.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5142
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210131/81d408db/attachment.htm>


More information about the bisq-github mailing list