[bisq-network/bitcoinj] Permit listening to version messages (#36)

dmos62 notifications at github.com
Thu Feb 4 15:36:31 CET 2021


This is the porting of PR #35 to BitcoinJ 15.8. I'll copy-paste the general description:

> Since Bisq requires nodes with specific configuration (as reflected in
their version messages), we also want to handle misconfigured nodes,
especially in cases where the user expects that node to be used. To get
access to all received version messages, a new listener is introduced.
Existing listeners are not sufficient, because in some cases BitcoinJ
will kill the Peer (connection to a node) before any of them are
triggered. This listener will always be triggered when a VersionMessage
is received.

[0] https://github.com/bisq-network/bitcoinj/pull/35
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bitcoinj/pull/36

-- Commit Summary --

  * Bump version string
  * Add VersionMessage received listener
  * Account for early AlertMessage receival
  * Fix javadoc comment

-- File Changes --

    M core/build.gradle (2)
    M core/src/main/java/org/bitcoinj/core/Peer.java (28)
    M core/src/main/java/org/bitcoinj/core/PeerGroup.java (71)
    M core/src/main/java/org/bitcoinj/core/VersionMessage.java (8)
    A core/src/main/java/org/bitcoinj/core/listeners/VersionMessageReceivedEventListener.java (34)

-- Patch Links --

https://github.com/bisq-network/bitcoinj/pull/36.patch
https://github.com/bisq-network/bitcoinj/pull/36.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/36
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210204/53931d1b/attachment-0001.htm>


More information about the bisq-github mailing list