[bisq-network/bisq] Improve facts and figures (#5156)

chimp1984 notifications at github.com
Fri Feb 5 07:41:31 CET 2021


Some notes:

- To fix the mixed comp requests and reimbursements in the earlier months @MwithM provided static data derived from Github data. 
- To be able to combine the data I needed to map it to the beginning of calender month. Using cycles instead is likely possible but more effort. 
- When using the timeline navigation the data in the textfields is updated as well to the filtered time period. It uses the same time raster than the chart.
- To show the time raster (months) in the tiemline navigation might be nice. Also to snap to the months selection would be nice. 
- Time timeline navigation would need a bit css magic to get a arrow handle to make it more clear its a naviation element.
- The attempt to extract the BTC fees from subracting reimbursement from proof of burn did not work well as there are periods where that would be negative. There is quite some delay between those 2 events. 
- Adding volume or price would not work as it would require an additional y-axis and that is not supported by the JavaFx charts and would require quite some extra effort.
- I am not sure if we should add 2 accumulated series: bsq-trade-fee + proof of burn and comp requests + reimbursement request. That would be then similar to the old version. As the BTC fee part is missing I think it would give an incorrect impression, but might still be useful.
- I would like to get the BTC fees in, but I think that is not trivial as we don't have natively those data. Once we have generated the data from blockchain explorer sources we can have a look if adding historical data would make sense or if it would require API calls to get up-to-date data.

Any dev who can help me with the css for the navigation timeline? Css is not my forte...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5156#issuecomment-773828740
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210204/fc39e1c1/attachment-0001.htm>


More information about the bisq-github mailing list