[bisq-network/bisq] Improve facts and figures (#5156)

[chimp1984]

Hi @cbeams 
Thanks for the feedback. As you mentioned yourself, I tried to to limit the effort/scope of that work, so my goal was to get the charts more usable for analysing our financial data. To finetune UI will take quite some more time and I will leave that for a dedicated UI dev who has already good experience with charting.

Here are some replies:

> It would be good to tighten up the vertical whitespace a bit

Yes will try to shink all a bit and make chart height smaller.

> It wasn't immediately obvious to me that the slider bar was actually a slider bar

Yes thats my main pain point as well and I asked if anyone can help here. CSS is not my strength and I I guess it requires some hacks as most of those detail nodes are not accessible via the chart API.

> It would be good to be able to mouse over the points on the graph and get an overlay showing the specific date, specific price / volume values

If there are not too many data points (e.g. select month) then there are tooltips. It turns off the symbol nodes in case too many data points get displayed, and so the tooltips.

> Speaking of that, I'm not sure why we're using line charts here in the DAO > Facts & Figures > Dashboard screen and using a column chart on the Market > Trades screen. Seems unnecessarily inconsistent

> use radio buttons

Agree. 

> BTC/USD price as an overlay
Would again required multiple y-axis.

Yes agree. I had a quick look to the market charts but they have quite a different implementation and custom bar nodes. If using default bars it requires category series and would have not worked as smooth with the time intervals. Can be all done but would take anothre few days work.

> in favor of a simpler date range picker experience

I think the time navigatio is one of the most useful feature and was a main reason why I started on that. I want to be able to  zoom into any historical date period. 

> combine the volume and price charts 

I wanted to do that first but the JavaFx charts are very basic and lack support for multiple y-axis, so that would be a bigger effort to extend charts and implement that. 

There is one missing feature I will add to that PR: To update the text fields with total burned BSQ, total issues/reimbured... according to the time period selection. I think its useful to be able to see what was total BSQ fees in Aug 2019 for instance. 

Additional to your suggestions I think it might be useful to have an exact date picker to select the data range. I had that initially but it was redundant to the time slider and I dropped it then. But it would help to get the numbers more exactly from the text fields (see above open feature). Now one does not see the exact selected time period and need to try to get close to the desired period. I did not find a good solution to not overload the chart with redundancy, but I think there would be a solution to get that feature. But again leave it to other devs... 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5156#issuecomment-776310536
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210209/4864bf5a/attachment.htm>