[bisq-network/bisq] Fix startup error: "You must have bootstrapped before adding data to the P2P network" (#5191)

jmacxx notifications at github.com
Sat Feb 13 23:07:17 CET 2021


`TriggerPriceService` is changed to use a `BootstrapListener` on the P2PService so that it can start after the P2P network is ready.

Fixes #5190 : Prevents an Uncaught Exception error at startup.

----

### To test (pre):

1. Create offer Buy, choosing "Deactivate offer if over x" price with a trigger price just above current spot.
2. Close down Bisq and wait for the market price to move over the deactivation price.
3. Start Bisq, the error message above will pop up.

### To test (post):

After applying this patch, at step 3 the offer will be deactivated successfully on startup and not produce an error popup.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5191

-- Commit Summary --

  * Fix issue with TriggerPriceService deactivating offer too early

-- File Changes --

    M core/src/main/java/bisq/core/offer/TriggerPriceService.java (22)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5191.patch
https://github.com/bisq-network/bisq/pull/5191.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5191
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210213/4c0cf27f/attachment.htm>


More information about the bisq-github mailing list