[bisq-network/bisq] Improve facts and figures (#5156)

Chris Beams notifications at github.com
Mon Feb 15 08:41:37 CET 2021


After spending more time with them, I'm really liking the new charts. Very useful, and I see now how the time slider is critically important to being able to drill down and get detailed information.

A couple additional, hopefully minor feedback issues:

- [ ] The state of the timeline slider is not persisted between view changes. So if I select a date range in `DAO > Facts and Figures > Dashboard` on one or both charts, and then switch to a different view, say `Market > Trades` and then switch back to `DAO > Facts and Figures > Dashboard`, my timeline slider gets reset to the default range.
- [ ] The BSQ/USD toggle should be labeled USD/BSQ, because what's actually being charted is "the number of USD per 1 BSQ", not the other way around. As it reads right now, it's confusing. I realize this isn't the only place in the UI that we use this reverse labeling, but perhaps we could at least do it correctly here and then change the other uses later.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5156#issuecomment-779019073
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210214/a1fccd85/attachment-0001.htm>


More information about the bisq-github mailing list