[bisq-network/bisq] Fix multiple request preliminary data calls (#5205)
chimp1984
notifications at github.com
Thu Feb 18 22:36:44 CET 2021
Fixes https://github.com/bisq-network/bisq/issues/5204
The PR is done in small improvements steps. Feel free to use final version instead of reviewing all commits.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5205
-- Commit Summary --
* Fixes https://github.com/bisq-network/bisq/issues/5204
* Call onNoSeedNodeAvailable on mailboxMessageService at onNoSeedNodeAvailable
* Merge onUpdatedDataReceived and onNoSeedNodeAvailable to onBootstrapped
* Call p2PDataStorage.onBootstrapComplete() before
* Refactor: Rename onBootstrapComplete to onBootstrapped
* Use same behaviour in onNoSeedNodeAvailable as in onUpdatedDataReceived
* Refactor: Extract method from duplicated code
* Call onNoSeedNodeAvailable if return value from requestPreliminaryData is false
* Remove boolean return value for requestPreliminaryData
-- File Changes --
M p2p/src/main/java/bisq/network/p2p/P2PService.java (38)
M p2p/src/main/java/bisq/network/p2p/mailbox/MailboxMessageService.java (32)
M p2p/src/main/java/bisq/network/p2p/peers/getdata/RequestDataManager.java (5)
M p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java (2)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5205.patch
https://github.com/bisq-network/bisq/pull/5205.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5205
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210218/c55182be/attachment.htm>
More information about the bisq-github
mailing list