[bisq-network/bisq] Fix initialization ordering issue (#5219)

chimp1984 notifications at github.com
Tue Feb 23 15:45:21 CET 2021


@chimp1984 approved this pull request.

ACK

I tested just that use case and it fixes the problem.

The underlying problem is that the order how listeners are registered and the domains are initialized is not sufficiently clearly organized.
SupportManager registers its listener in the constructor, others in onAllServicesInitialized.

Listener are moslty held in HashSets, so the order of execution is not related to the order how they get added, which is semantically correct as listeners should not rely on order of execution, but as we see the domains would require more precise order.

It would require a larger refactoring to get those processes better defined.
I think the suggested fix carries probably low risk but all main use cases specailly those involving mailbox messages should be tested well.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5219#pullrequestreview-596412887
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210223/e7e4d02b/attachment.htm>


More information about the bisq-github mailing list