[bisq-network/bisq] Obtain minimumFee from mempool api in place of hardcoded value (#5235)
jmacxx
notifications at github.com
Thu Feb 25 05:34:05 CET 2021
Fixes #5229
**example data from mempool api:**
{"fastestFee":35,"halfHourFee":28,"hourFee":25,"minimumFee":6}
**Bisq pricenode obtains fee info:**
Feb-24 22:10:45.291 [Timer-25] INFO b.p.m.p.MempoolFeeRateProvider$First: Retrieved estimated mining fee of 28 sat/vB and minimumFee of 12 sat/vB from mempool.space
Feb-24 22:10:45.500 [Timer-25] INFO b.p.m.p.MempoolFeeRateProvider$Fourth: Retrieved estimated mining fee of 27 sat/vB and minimumFee of 12 sat/vB from mempool.bisq.services
Feb-24 22:10:46.767 [Timer-25] INFO b.p.m.p.MempoolFeeRateProvider$Second: Retrieved estimated mining fee of 27 sat/vB and minimumFee of 12 sat/vB from mempool.emzy.de
Feb-24 22:10:47.307 [Timer-25] INFO b.p.m.p.MempoolFeeRateProvider$Third: Retrieved estimated mining fee of 27 sat/vB and minimumFee of 12 sat/vB from mempool.ninja
---
**averaged fee data published by PriceNode:**
{
"bitcoinFeesTs" : 1614226269,
"dataMap" : {
"btcTxFee" : 27,
"btcMinTxFee" : 12
}
}
---
**Bisq app obtains fee from PriceNode:**
INFO b.core.provider.fee.FeeService: BTC tx fee: txFeePerVbyte=27 minFeePerVbyte=12
---
**Bisq withdrawal fee rate in settings screen cannot be set below the minFeePerVbyte**
![image](https://user-images.githubusercontent.com/47253594/109102970-912f7580-76ef-11eb-9431-4459a7f0c854.png)
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5235
-- Commit Summary --
* Obtain minimumFee from mempool api in place of hardcoded value
-- File Changes --
M core/src/main/java/bisq/core/provider/fee/FeeProvider.java (4)
M core/src/main/java/bisq/core/provider/fee/FeeService.java (6)
M core/src/main/java/bisq/core/user/Preferences.java (6)
M desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java (2)
M pricenode/src/main/java/bisq/price/mining/FeeRate.java (8)
M pricenode/src/main/java/bisq/price/mining/FeeRateService.java (8)
M pricenode/src/main/java/bisq/price/mining/providers/MempoolFeeRateProvider.java (41)
M pricenode/src/test/java/bisq/price/mining/FeeRateServiceTest.java (2)
M pricenode/src/test/java/bisq/price/mining/providers/MempoolFeeRateProviderTest.java (2)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5235.patch
https://github.com/bisq-network/bisq/pull/5235.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5235
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210224/57c8318b/attachment-0001.htm>
More information about the bisq-github
mailing list