[bisq-network/bisq] Adjust api to new minimum fee per vbyte (#5238)

[Stan]

Since PR https://github.com/bisq-network/bisq/pull/5224, the `BaseCurrencyNetwork#getDefaultMinFeePerVbyte`  returns 15 (sats/byte).  See commit b341bb6e891c9a6f8ebb9ac9a94c919e0ce18d74.

This change adjusts the api to the new min tx fee rate by validating the api's setTxFeeRatePreference param, and throwing an appropriate  exception if the param value is below the minimum.  Also adjusted a broken test, and added a new test to check the  exception.


**TODO** Prepare to adjust api again to a different minimum fee per vbyte.  Commit c33ac1b9834fb9f7f14e553d09776f94efc9d13d changed the source of the min tx fee rate (`FeeService`), and the api will adjust after the associated PR https://github.com/bisq-network/bisq/pull/5235 is merged.  For now, the required change is a comment.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5238

-- Commit Summary --

  * Make @VisibleForTesting
  * Add CLI testing bot to :apitest
  * Merge branch 'master' into 02-scripted-bot-test
  * Fix manual shutdown exception handling
  * Merge branch 'master' into 02-scripted-bot-test
  * Add --help option to bot-script.json generator
  * Merge branch 'master' into 02-scripted-bot-test
  * Fix typo in toString
  * Adjust api to new minimum fee per vbyte
  * Prepare to adjust api to new minimum fee per vbyte (from feeService)

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/wallet/BtcTxFeeRateTest.java (24)
    A apitest/src/test/java/bisq/apitest/scenario/ScriptedBotTest.java (126)
    M apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (3)
    A apitest/src/test/java/bisq/apitest/scenario/bot/AbstractBotTest.java (110)
    A apitest/src/test/java/bisq/apitest/scenario/bot/Bot.java (77)
    A apitest/src/test/java/bisq/apitest/scenario/bot/BotClient.java (386)
    A apitest/src/test/java/bisq/apitest/scenario/bot/BotPaymentAccountGenerator.java (68)
    A apitest/src/test/java/bisq/apitest/scenario/bot/InvalidRandomOfferException.java (35)
    A apitest/src/test/java/bisq/apitest/scenario/bot/PaymentAccountNotFoundException.java (35)
    A apitest/src/test/java/bisq/apitest/scenario/bot/RandomOffer.java (177)
    A apitest/src/test/java/bisq/apitest/scenario/bot/RobotBob.java (141)
    A apitest/src/test/java/bisq/apitest/scenario/bot/protocol/BotProtocol.java (349)
    A apitest/src/test/java/bisq/apitest/scenario/bot/protocol/MakerBotProtocol.java (114)
    A apitest/src/test/java/bisq/apitest/scenario/bot/protocol/ProtocolStep.java (17)
    A apitest/src/test/java/bisq/apitest/scenario/bot/protocol/TakerBotProtocol.java (136)
    A apitest/src/test/java/bisq/apitest/scenario/bot/script/BashScriptGenerator.java (235)
    A apitest/src/test/java/bisq/apitest/scenario/bot/script/BotScript.java (78)
    A apitest/src/test/java/bisq/apitest/scenario/bot/script/BotScriptGenerator.java (247)
    A apitest/src/test/java/bisq/apitest/scenario/bot/shutdown/ManualBotShutdownException.java (35)
    A apitest/src/test/java/bisq/apitest/scenario/bot/shutdown/ManualShutdown.java (64)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (16)
    M cli/src/main/java/bisq/cli/TableFormat.java (4)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (10)
    M core/src/main/java/bisq/core/api/model/TxFeeRateInfo.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5238.patch
https://github.com/bisq-network/bisq/pull/5238.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5238
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210225/08fe30d0/attachment-0001.htm>