[bisq-network/bisq] Obtain minimumFee from mempool api in place of hardcoded value (#5235)

[Stan]

@ghubstan commented on this pull request.

I'm done with the review, but hold back on an ACK because I want to know if the old `BaseCurrencyNetwork#getDefaultMinFeePerVbyte` method can be removed if never to be used again.  (I'm chasing these min fee rate changes in the api+tests).

> @@ -907,7 +911,7 @@ public boolean getPayFeeInBtc() {
 
     public long getWithdrawalTxFeeInVbytes() {
         return Math.max(prefPayload.getWithdrawalTxFeeInVbytes(),
-                Config.baseCurrencyNetwork().getDefaultMinFeePerVbyte());

Will `BaseCurrencyNetwork.getDefaultMinFeePerVbyte()` be `@Deprecated` and/or removed?  

> @@ -157,14 +158,15 @@ public void onSuccess(@Nullable Tuple2<Map<String, Long>, Map<String, Long>> res
                         epochInSecondAtLastRequest = timeStampMap.get("bitcoinFeesTs");
                         final Map<String, Long> map = result.second;
                         txFeePerVbyte = map.get("BTC");
+                        minFeePerVByte = map.get("btcMinTxFee");

Just because this map key `btcMinTxFee` is used in at least one other class, should it be defined as a static field in one class to avoid typos?   I'm not sure, but it's something to consider...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5235#pullrequestreview-598668773
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210225/be4f11af/attachment.htm>