[bisq-network/bisq] Obtain minimumFee from mempool api in place of hardcoded value (#5235)

jmacxx notifications at github.com
Thu Feb 25 18:17:33 CET 2021


@jmacxx commented on this pull request.



> @@ -157,14 +158,15 @@ public void onSuccess(@Nullable Tuple2<Map<String, Long>, Map<String, Long>> res
                         epochInSecondAtLastRequest = timeStampMap.get("bitcoinFeesTs");
                         final Map<String, Long> map = result.second;
                         txFeePerVbyte = map.get("BTC");
+                        minFeePerVByte = map.get("btcMinTxFee");

Yes great idea, in fact I did run into a scenario like that during testing.  So I will extract those hardcoded strings shared between Bisq and PriceNode into `Common/Config.java`.  Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5235#discussion_r583017157
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210225/9f7981b3/attachment.htm>


More information about the bisq-github mailing list