[bisq-network/bisq] Refactor grpc stub boilerplate from CliMain to GrpcClient (#5240)

[Stan]

`CliMain` no longer uses `gRPC` stubs directly, just parses & validates command options, and prints responses.

Also, anticipates reuse by java bots (avoiding grpc boilerplate duplication on the client side), reduces size of `CliMain` class, and will allow clean up of duplicated grpc boilerplate in apitest cases.

PR https://github.com/bisq-network/bisq/pull/5238 should be reviewed/merged before this one.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5240

-- Commit Summary --

  * Make @VisibleForTesting
  * Add CLI testing bot to :apitest
  * Merge branch 'master' into 02-scripted-bot-test
  * Fix manual shutdown exception handling
  * Merge branch 'master' into 02-scripted-bot-test
  * Add --help option to bot-script.json generator
  * Merge branch 'master' into 02-scripted-bot-test
  * Fix typo in toString
  * Adjust api to new minimum fee per vbyte
  * Prepare to adjust api to new minimum fee per vbyte (from feeService)
  * Refactor grpc stub boilerplate from CliMain to GrpcClient

-- File Changes --

    M apitest/src/test/java/bisq/apitest/method/wallet/BtcTxFeeRateTest.java (24)
    A apitest/src/test/java/bisq/apitest/scenario/ScriptedBotTest.java (126)
    M apitest/src/test/java/bisq/apitest/scenario/WalletTest.java (3)
    A apitest/src/test/java/bisq/apitest/scenario/bot/AbstractBotTest.java (110)
    A apitest/src/test/java/bisq/apitest/scenario/bot/Bot.java (77)
    A apitest/src/test/java/bisq/apitest/scenario/bot/BotClient.java (386)
    A apitest/src/test/java/bisq/apitest/scenario/bot/BotPaymentAccountGenerator.java (68)
    A apitest/src/test/java/bisq/apitest/scenario/bot/InvalidRandomOfferException.java (35)
    A apitest/src/test/java/bisq/apitest/scenario/bot/PaymentAccountNotFoundException.java (35)
    A apitest/src/test/java/bisq/apitest/scenario/bot/RandomOffer.java (177)
    A apitest/src/test/java/bisq/apitest/scenario/bot/RobotBob.java (141)
    A apitest/src/test/java/bisq/apitest/scenario/bot/protocol/BotProtocol.java (349)
    A apitest/src/test/java/bisq/apitest/scenario/bot/protocol/MakerBotProtocol.java (114)
    A apitest/src/test/java/bisq/apitest/scenario/bot/protocol/ProtocolStep.java (17)
    A apitest/src/test/java/bisq/apitest/scenario/bot/protocol/TakerBotProtocol.java (136)
    A apitest/src/test/java/bisq/apitest/scenario/bot/script/BashScriptGenerator.java (235)
    A apitest/src/test/java/bisq/apitest/scenario/bot/script/BotScript.java (78)
    A apitest/src/test/java/bisq/apitest/scenario/bot/script/BotScriptGenerator.java (247)
    A apitest/src/test/java/bisq/apitest/scenario/bot/shutdown/ManualBotShutdownException.java (35)
    A apitest/src/test/java/bisq/apitest/scenario/bot/shutdown/ManualShutdown.java (64)
    M cli/src/main/java/bisq/cli/CliMain.java (361)
    M cli/src/main/java/bisq/cli/CurrencyFormat.java (16)
    A cli/src/main/java/bisq/cli/GrpcClient.java (326)
    M cli/src/main/java/bisq/cli/GrpcStubs.java (2)
    M cli/src/main/java/bisq/cli/TableFormat.java (4)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (10)
    M core/src/main/java/bisq/core/api/model/TxFeeRateInfo.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5240.patch
https://github.com/bisq-network/bisq/pull/5240.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5240
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210225/eca8f962/attachment.htm>