[bisq-network/bisq] Display buyer's cost in api's gettrade output (#5246)
Stan
notifications at github.com
Fri Feb 26 19:32:49 CET 2021
The trade offer's volume is shown so traders know how much fiat they are sending or receiving without having to call `getoffer`.
- Changed the `Fiat Sent` and `Fiat Received` column headers to show which fiat is being transferred, e.g.,
`EUR Sent`, `EUR Received`.
- Adjusted apitest's `trade-simulation-utils.sh` to the modified `gettrade` output.
Below is a sample of the new `gettrade` output.
`./bisq-cli --password=xyz --port=9999 gettrade --trade-id=4954970-7fcc4ae0-8f2a-4dbd-acfa-c692a42f42b1-156`
```
ID My Role Price in USD for 1 BTC Amount(BTC) Tx Fee(BTC) Taker Fee(BTC) Deposit Published Deposit Confirmed Buyer Cost(USD) USD Sent USD Received Payout Published Withdrawn
4954970 BTC buyer as taker 49,689.7997 0.12500000 0.00031164 0.00000019 YES YES 6,211 YES YES YES NO
```
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5246
-- Commit Summary --
* Display buyer's cost in api's gettrade output
-- File Changes --
M apitest/scripts/trade-simulation-utils.sh (12)
M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (10)
M cli/src/main/java/bisq/cli/TradeFormat.java (33)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5246.patch
https://github.com/bisq-network/bisq/pull/5246.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5246
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210226/f7406d1f/attachment.htm>
More information about the bisq-github
mailing list