[bisq-network/bisq] Improve gRPC server error logging (#5249)
Stan
notifications at github.com
Sat Feb 27 21:34:43 CET 2021
- Use the logger of the `gRPC` service throwing the exception, not the exception handler's logger.
- Log `trade not found` exceptions as warnings instead cluttering the log with full stack traces.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/5249
-- Commit Summary --
* Display buyer's cost in api's gettrade output
* Merge branch 'master' into 01-show-cost-in-trade-output
* Use the logger of the gRPC service throwing an exception
* Permit some gRPC excptions to be logged only as warning
* Log 'trade not found' a warning instead of full stack trace
-- File Changes --
M apitest/scripts/trade-simulation-utils.sh (12)
M cli/src/main/java/bisq/cli/ColumnHeaderConstants.java (10)
M cli/src/main/java/bisq/cli/TradeFormat.java (33)
M daemon/src/main/java/bisq/daemon/grpc/GrpcDisputeAgentsService.java (2)
M daemon/src/main/java/bisq/daemon/grpc/GrpcExceptionHandler.java (18)
M daemon/src/main/java/bisq/daemon/grpc/GrpcGetTradeStatisticsService.java (5)
M daemon/src/main/java/bisq/daemon/grpc/GrpcHelpService.java (2)
M daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java (12)
M daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java (12)
M daemon/src/main/java/bisq/daemon/grpc/GrpcPriceService.java (2)
M daemon/src/main/java/bisq/daemon/grpc/GrpcShutdownService.java (2)
M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (16)
M daemon/src/main/java/bisq/daemon/grpc/GrpcVersionService.java (2)
M daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java (28)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/5249.patch
https://github.com/bisq-network/bisq/pull/5249.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5249
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210227/983fb1de/attachment.htm>
More information about the bisq-github
mailing list