[bisq-network/bisq] Translate checkArgument messages (#4978)

[sqrrm]

@sqrrm requested changes on this pull request.

In general I don't think it's worth moving these strings to resources. Some do have value as they're useful for users, but it's mostly meant as a way to trouble shoot issues together with users, or as a safety check that should never happen but just a good to have.

Adding more strings to resources adds more work for translators for very little benefit. I can still see the benefit of some of these strings so would ack if @ManfredKarrer agrees, as this is a change to core DAO code which can't be merged without his ack as per project guidelines.

>          // buyerAmount can be 0
         if (buyerAmount.isPositive()) {
             Preconditions.checkArgument(Restrictions.isAboveDust(buyerAmount),
-                    "The buyerAmount is too low (dust limit).");
+                    Res.get("validation.amountBelowDust.shortVar", "buyerAmount"));

This kind of argument defeats the aim of making the strings translatable. In this case it's better to just make two strings, or reuse `validation.amountBelowDust.short`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4978#pullrequestreview-560593661
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210101/ffe724e4/attachment.htm>