[bisq-network/bisq] Adjust lombok annotations to reduce build warnings (#5021)

chimp1984 notifications at github.com
Sat Jan 2 18:44:34 CET 2021


@chimp1984 requested changes on this pull request.



> @@ -36,7 +37,8 @@
  * Gets persisted.
  */
 @Immutable
- at Data
+ at Getter
+ at Setter

There is no write access and its Immutable. The @Data was wrong and should have been a @Value annotation.
Can you remove the @Setter?

> @@ -21,9 +21,11 @@
 import bisq.common.app.Version;
 import bisq.common.proto.network.NetworkEnvelope;
 
+import lombok.EqualsAndHashCode;
 import lombok.Value;
 
 @Value

That should also be replaced by a @Getter and @ToString.

> @@ -28,9 +28,11 @@
 import java.util.HashMap;
 import java.util.Map;
 
+import lombok.EqualsAndHashCode;
 import lombok.Value;
 
 @Value

That should also be replaced by a @Getter and @ToString.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5021#pullrequestreview-560647019
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210102/77367c84/attachment.htm>


More information about the bisq-github mailing list