[bisq-network/bisq] Add cache for signature verification results and a lookup map by ownerPubKey (#5047)

chimp1984 notifications at github.com
Sat Jan 2 23:22:10 CET 2021


When adding a new filter to the offer book it became has shown that there are some performance bottlenecks in the signedWitness domain. With Profiling 2 methods have been found causing the main costs.

Before that optimisation the new filter took about 265 ms (200 ms for the signature checks and 65 ms for the iteration testing for same ownerPubKeys. After the optimisation it is about 15 ms. 

This code was also called already by the item renderer for the take offer button to show if it is enabled or not. So the offer book becomes faster as well.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5047

-- Commit Summary --

  * Add cache for signature verification results and a lookup map by ownerPubKey

-- File Changes --

    M core/src/main/java/bisq/core/account/sign/SignedWitnessService.java (40)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5047.patch
https://github.com/bisq-network/bisq/pull/5047.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5047
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210102/3ccacb98/attachment.htm>


More information about the bisq-github mailing list