[bisq-network/bisq] Add filter support on network level (#5038)

chimp1984 notifications at github.com
Mon Jan 4 00:31:42 CET 2021


@chimp1984 commented on this pull request.



> @@ -91,6 +95,11 @@
     // added at v1.3.8
     private final boolean disableAutoConf;
 
+    // added at v1.5.5
+    // In contrast to bannedNodeAddress those addresses cannot access the network but are rejected immediately.
+    // Should be only used in case of dos attacks
+    private final Set<String> nodeAddressesBannedFromNetwork;

I think `nodeAddressesBannedFromNetwork` is pretty clear (and long ;-)) no? The `bannedNodeAddress` is not great but renaming it would require a rename if the protobuf field as well to avoid that those fields get out of sync and was not sure if thats worth it. Also not clear for a good alternative name. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5038#discussion_r551068832
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210103/96294b19/attachment.htm>


More information about the bisq-github mailing list