[bisq-network/bisq] Add filter support on network level (#5038)

sqrrm notifications at github.com
Mon Jan 4 10:36:26 CET 2021


@sqrrm commented on this pull request.



> @@ -91,6 +95,11 @@
     // added at v1.3.8
     private final boolean disableAutoConf;
 
+    // added at v1.5.5
+    // In contrast to bannedNodeAddress those addresses cannot access the network but are rejected immediately.
+    // Should be only used in case of dos attacks
+    private final Set<String> nodeAddressesBannedFromNetwork;

Much better this way, no need for comments since code is self describing. Agreed that it was the `bannedNodeAddress` that needed a name change.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5038#discussion_r551204787
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210104/d7b2d83e/attachment.htm>


More information about the bisq-github mailing list