[bisq-network/bisq] Add protection tools (#5053)

[chimp1984]

> @chimp1984 The filter added to `CoreOffersService` `getOffer` and `getOffers` prevents api users from seeing their own offers.
> Adding a new `getmyoffers` doesn't see right. Any suggestions?
> 
> Also, this filter is flushing out bugs in some of my offer/trade aptest cases, first one: creating offers for other fiat currencies than the dummy acct's currency, but that should be easy to fix. There may be other problems to be found while using this new filter...

Ah true. It filters out all offers you cannot take, including your own ones. I assume the getOffer/getOffers methods are primarily used for finding an offer to take. To browse through offers for informational purpose seems not a real use-case, no? 

We could add a getAllOffers method (without the filter) if that makes sense. It just should be clear that those are not usable for selecting to take an offer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5053#issuecomment-754234312
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210104/6fff38c7/attachment-0001.htm>