[bisq-network/bisq] Add "Buy BSQ" button next to trade fee selector (#5055)
Jakub Loucký
notifications at github.com
Tue Jan 5 01:55:37 CET 2021
I've been trying to resolve the combo box focus issue for a long time, with not much success. I tried the following:
- disable the combo box temporarily,
- disable the focus listener of the combo box temporarily, or `setFocusTraversable(false)`,
- `requestFocus()` on another element, right around the time the tab switching takes place (this resolved only some cases, mostly the 2nd item in my checkbox list above),
- and much more.
These either had no effect, or caused the combo box not to reflect `sellScreenCurrencyCode` in Preferences.
Also, when the combo box receives focus, it's probably happening too early, as indicated by the fact that the drop-down list is rendered incorrectly - it's shifted to the left:
![Buy BSQ tab select - combobox focus bug](https://user-images.githubusercontent.com/16313562/103592954-b7594600-4ef4-11eb-8669-e19da2f11593.png)
### Some options that I see:
- carefuly rework AutocompleteComboBox. Instead of relying on onFocus, use onClick; I tried that already, but then the value in the combo box wasn't in line with `sellScreenCurrencyCode` in Preferences.
- instead of clearing the value when focused, just select the contents of the edit text field; thus, the previous value will not be lost, and users can still very easily filter by typing right away.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-754317263
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210104/c2accdf1/attachment-0001.htm>
More information about the bisq-github
mailing list